Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the --build-id-pat option #4874

Open
2 of 3 tasks
travishathaway opened this issue May 8, 2023 · 2 comments
Open
2 of 3 tasks

Add documentation for the --build-id-pat option #4874

travishathaway opened this issue May 8, 2023 · 2 comments
Labels
good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward source::anaconda created by members of Anaconda, Inc. stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability

Comments

@travishathaway
Copy link
Contributor

travishathaway commented May 8, 2023

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

The --build-id-pat is currently poorly documented. There is no information on how to provide a meaningful value for this configuration option.

Why is this needed?

To reduce confusion around this configuration option.

What should happen?

  • Add documentation for this option to the CLI and the documentation website. This documentation should include the template variables that can be used and an example of its usage.

Additional Context

This issue was created in response to concerns initially brought up in this issue:

@travishathaway travishathaway added type::feature request for a new feature or capability good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward source::anaconda created by members of Anaconda, Inc. labels May 8, 2023
@travishathaway
Copy link
Contributor Author

travishathaway commented May 8, 2023

I dug around the code a little bit and discovered that it defaults to the following:

p.add_argument(
"--build-id-pat",
help=(
"specify a templated pattern to use as build folder names. Use if having issues with "
"paths being too long."
),
dest="build_id_pat",
default=cc_conda_build.get("build_id_pat", "{n}_{t}"),
)

This is part of the documentation that should be updated for the CLI. We show also have an example in our documentation too.

There's also another place in the code where this pattern occurs:

{n}-{v}_{t}

Where: n = package name, v = version and t = timestamp.

Source:

pat_dict = {"n": package_name, "v": str(package_version), "t": "{t}"}

Copy link

github-actions bot commented May 8, 2024

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward source::anaconda created by members of Anaconda, Inc. stale [bot] marked as stale due to inactivity type::feature request for a new feature or capability
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant