Parse destructuring of assignment statements. #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12371 Bundle Size — 62.48MiB (+0.03%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
|
| Current #12371 |
Baseline #12344 |
|
|---|---|---|
 Initial JS |
45.54MiB(+0.01%) |
45.54MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.23% |
21.69% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4374 |
4374 |
| Duplicate Modules |
504 |
504 |
| Duplicate Code |
30.83%(+0.03%) |
30.82% |
| Packages |
468 |
468 |
| Duplicate Packages |
58 |
58 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #12371 |
Baseline #12344 |
|
|---|---|---|
| JS |
62.47MiB (+0.03%) |
62.45MiB |
| HTML |
10.94KiB (-0.34%) |
10.97KiB |
Bundle analysis report Branch feature/parse-destructuring-of-a... Project dashboard
|
Performance test results: |
…g-of-assignment-statements
Merged
…g-of-assignment-statements
bkrmendy
reviewed
May 9, 2024
bkrmendy
approved these changes
May 9, 2024
ruggi
reviewed
May 9, 2024
- Prevent tracing through spread objects or arrays. - Widen `hookCallRegex` a little.
balazsbajorics
approved these changes
May 13, 2024
seanparsons
deleted the
feature/parse-destructuring-of-assignment-statements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We need more detail in the assignment statements so that we can track destructuring.
Fix:
We already have
Paramand some associated types which handle the destructuring for function parameters and the TypeScript compiler uses the same underlying representation in both cases (function parameters and variable declarations). As a result in this we use that existing functionality to handle the same type of parsing for the variable declarations.Commit Details:
JSAssignment.leftHandSideto be an instance ofBoundParam.Paramrelated fields fromJSExpressionMapOrOtherJavascripttoJSExpression.clearArbitraryJSBlockSourceMaps,clearDestructuredArrayPartSourceMaps,clearDestructuredParamPartSourceMaps,clearParamSourceMaps,clearBoundParamSourceMaps,clearBoundParamUniqueIDsAndSourceMaps,clearTopLevelElementSourceMaps,clearJSAssignmentSourceMaps,clearJSArbitraryStatementSourceMaps,clearParseResultSourceMapsUniqueIDsAndEmptyBlocksandclearTopLevelElementSourceMapsUniqueIDsAndEmptyBlocksutility functions.parseDeclarationnow usesparseBindingNameto produce the expected representation forJSAssignmentvalues.lookupIntoComponentScope.Manual Tests:
I hereby swear that: