Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make style section hideable and suppressable #5635

Open
11 tasks done
maltenuhn opened this issue May 8, 2024 · 2 comments · Fixed by #5723
Open
11 tasks done

Make style section hideable and suppressable #5635

maltenuhn opened this issue May 8, 2024 · 2 comments · Fixed by #5723
Assignees
Labels
Inspector Affects the inspector, settings, commands
Milestone

Comments

@maltenuhn
Copy link
Member

maltenuhn commented May 8, 2024

Problems

  • The style section and its subsections are difficult to work with and understand, especially for components.
  • Additionally, the completely hiding the style section was not well received.

Solution
Part 1

  • Create a new "Styles" (sic) Section
  • Make that capable of folding in and out the entire set of existing style subsections
  • use the Utopia API to expand, collapse, or hide this new section (bikeshed the naming)

Part 2

  • Create a new Section called "Advanced"
  • Relabel the Target Selector subsection / component as "Target" (not 'style')
  • Relabel the CSS Classname subsection (the one we show when Tailwind is enabled) as 'CSS'
  • Move them into the "Advanced" section
  • Make the 'advanced' subsection closed contracted by default (so you don't see the Target and CSS subsections

Part 3: Defaults and Component API

  • For components, collapse the new Styles section by default.
  • API should allow showing it as collapsed, expanded, and hidden (bikedshed labels...), and section should respect that
  • for elements, expand the Styles section by default
@maltenuhn maltenuhn assigned lankaukk and unassigned lankaukk May 8, 2024
@maltenuhn maltenuhn added this to the 1. Creation milestone May 13, 2024
@maltenuhn maltenuhn added the Inspector Affects the inspector, settings, commands label May 14, 2024
@bkrmendy bkrmendy self-assigned this May 21, 2024
@bkrmendy bkrmendy linked a pull request May 21, 2024 that will close this issue
2 tasks
@bkrmendy
Copy link
Contributor

bkrmendy commented May 21, 2024

#5719 implements the UI parts

@bkrmendy
Copy link
Contributor

#5723 adds the component API parts

@bkrmendy bkrmendy linked a pull request May 27, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Inspector Affects the inspector, settings, commands
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants