Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context menu positioning for real #5633

Open
gbalint opened this issue May 8, 2024 · 1 comment
Open

Fix context menu positioning for real #5633

gbalint opened this issue May 8, 2024 · 1 comment

Comments

@gbalint
Copy link
Contributor

gbalint commented May 8, 2024

This fix was just a temporary hack, fix it properly:

#5613

This bug affects other context menus using MenuProvider (e.g. dependency list items context menu).
It is probably enough to follow the patterns of the context menus which work well, e.g. the insert/replace menu in the navigator.

@maltenuhn
Copy link
Member

It is probably enough to follow the patterns of the context menus which work well, e.g. the insert/replace menu in the navigator.
for the note: that menu does work better, but does not work well either, because it's positioned relative to the mouse position, not the button... We will need a new component for menus contextual to an element (no idea what to call that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants