Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data picker scroll #5617

Merged
merged 1 commit into from
May 6, 2024
Merged

Data picker scroll #5617

merged 1 commit into from
May 6, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented May 6, 2024 •
edited

Problem:
Data picker insertion list is not scrollable
image

Fix:
Give the list a sensible max height and a scrolling list
image

Fixes #5600

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented May 6, 2024

#12306 Bundle Size — 62.48MiB (~+0.01%).

804ff11(current) vs 6339ece master#12303(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#12306		      Baseline
#12303
Regression  Initial JS 45.56MiB(~+0.01%) 45.55MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.09% 21.74%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4378 4378
No change  Duplicate Modules 504 504
No change  Duplicate Code 30.81% 30.81%
No change  Packages 468 468
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#12306		      Baseline
#12303
Regression  JS 62.47MiB (~+0.01%) 62.47MiB
Improvement  HTML 10.94KiB (-0.34%) 10.98KiB

Bundle analysis report Branch fix/data-picker-scroll Project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Performance test results:
(Chart1)
(Chart2)

@liady liady merged commit 6d83a0e into master May 6, 2024
16 checks passed
@liady liady deleted the fix/data-picker-scroll branch May 6, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data picker insertion list should be scrollable
3 participants
@liady @Rheeseyb @balazsbajorics