We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On GHC-8.6.5, in a PR based on 5d096df
Failures: Streamly/Test/Unicode/Stream.hs:177:9: 1) Unicode.Stream, UTF8 - Encoding / Decoding, Arrays Streamly.Data.String.lines == Prelude.lines Assertion failed (after 766 tests): zipAsyncly Compose three - empty in the middle [✔] [48,89,237,128,185,236,161,51,229,204,167,5,154,15,252,80,71,15,179,204] To rerun use: --match "/Unicode.Stream/UTF8 - Encoding / Decoding/Arrays Streamly.Data.String.lines == Prelude.lines/" --seed 1380626044 +++ OK, passed 100 tests. Randomized with seed 1380626044
The relevant test is:
testLinesArray :: Property testLinesArray = forAll genWord8 $ \list -> monadicIO $ do xs <- Stream.toList $ fmap A.toList $ AS.splitOnSuffix 10 $ Stream.fromPure (A.fromList list) assert (xs == map (map (fromIntegral . ord)) (lines (map (chr . fromIntegral) list)))
Could be an issue with AS.splitOnSuffix?
{-# INLINE splitOnSuffix #-} splitOnSuffix :: (MonadIO m) => Word8 -> Stream m (Array Word8) -> Stream m (Array Word8) splitOnSuffix = Array.compactOnByteSuffix
{-# INLINE compactOnByteSuffix #-} compactOnByteSuffix :: (MonadIO m) => Word8 -> Stream m (Array Word8) -> Stream m (Array Word8) compactOnByteSuffix byte = fmap unsafeFreeze . MA.compactOnByteSuffix byte . fmap unsafeThaw
{-# INLINE compactOnByteSuffix #-} compactOnByteSuffix :: (MonadIO m) => Word8 -> Stream m (MutArray Word8) -> Stream m (MutArray Word8) compactOnByteSuffix byte = -- XXX use spliceExp and rightSize? Stream.splitInnerBySuffix (\arr -> byteLength arr == 0) (breakOn byte) splice
breakOn uses unpinned pointer in memcpy, could it be because of that?
breakOn
The text was updated successfully, but these errors were encountered:
No branches or pull requests
On GHC-8.6.5, in a PR based on 5d096df
The relevant test is:
Could be an issue with AS.splitOnSuffix?
breakOn
uses unpinned pointer in memcpy, could it be because of that?The text was updated successfully, but these errors were encountered: