Fix printing of Vararg on Julia 1.7 #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you just copy-paste the example from that issue in the test? that should be sufficient as a test |
Codecov ReportAttention:
... and 22 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Recent versions of Julia has moved Vararg from being a Type to being its own thing. This means it will error if T is a vararg and you try to do `isa` to `<:` operations with it. This caused an error, which is fixed here by explicitly testing if T is a Vararg.
jakobnissen
force-pushed
the
fix_vararg
branch
from
1e5618a
to
04bad43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Julia has moved Vararg from being a Type to being its own thing. This means it will error if T is a vararg and you try to do
isato<:operations with it.This caused an error, which is fixed here by explicitly testing if T is a Vararg.
Fixes #261
Note that THIS IS NOT TESTED! I couldn't figure out how to write a test for this.