Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should provide some feedback (spinner) while waiting for data to load #5714

Open
mnalis opened this issue May 5, 2024 · 2 comments · May be fixed by #5736
Open

App should provide some feedback (spinner) while waiting for data to load #5714

mnalis opened this issue May 5, 2024 · 2 comments · May be fixed by #5736

Comments

@mnalis
Copy link
Contributor

mnalis commented May 5, 2024

Feedback

Here is example, look e.g. at 00:00:06 there is missing picture and no indication that app is loading it, and it is isn't until 00:00:15 (and that is on the fast wifi!) until picture is loaded and the user is left wondering in the meantime what is happening.

small_Screen_Recording_20240505_044940_Commons.mp4

Another situation is e.g. waiting for categories (see #5316)

In general, procedure when app tries to do some user-initiated (i.e. UI thread) potentially-time-consuming-task (e.g. network-oriented) should be:

  • show the "loading..." spinner image (nicer if animated, but not a requirement, can be simple "Please wait..." text on the middle of the screen too)
  • start the (network, or other potentially time consuming) task
  • wait for task to finish
  • remove the spinner

Wiki username

Mnalis

Device name

Samsung Galaxy S23+

Android version

Android 14 (OneUI 6.1)

Commons app version

5.0.1~af028cbdd (latest F-droid)

@vtalos
Copy link
Contributor

vtalos commented May 9, 2024

I would like to work on this with @karyotakisg. Could we get assigned?

@nicolas-raoul
Copy link
Member

@vtalos @karyotakisg It is yours, thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@nicolas-raoul @mnalis @vtalos and others