Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure of uploadCancelledAfterLocationPickedTest and testBetaSkipButton #5355

Open
nicolas-raoul opened this issue Oct 20, 2023 · 6 comments · May be fixed by #5508
Open

Failure of uploadCancelledAfterLocationPickedTest and testBetaSkipButton #5355

nicolas-raoul opened this issue Oct 20, 2023 · 6 comments · May be fixed by #5508
Assignees
@RitikaPahwa4444
Labels
bug

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Oct 20, 2023 •
edited

Not too sure what it is, but I see some unit tests failing in CI:

https://github.com/commons-app/apps-android-commons/actions/runs/6582881080/job/17885059535#step:8:458

fr.free.nrw.commons.UploadCancelledTest > uploadCancelledAfterLocationPickedTest[test(AVD) - 7.0] FAILED 
	androidx.test.espresso.NoMatchingViewException: No views in hierarchy found matching: (view.getId() is <2131296394/fr.free.nrw.commons.beta:id/caption_item_edit_text> and Child at position 0 in parent Child at position 0 in parent view.getId() is <2131296395> and (view has effective visibility <VISIBLE> and view.getGlobalVisibleRect() to return non-empty rectangle))
	
fr.free.nrw.commons.UploadTest > testUploadWithMultilingualDescription[test(AVD) - 7.0] SKIPPED 

fr.free.nrw.commons.UploadTest > testUploadWithoutDescription[test(AVD) - 7.0] SKIPPED 

fr.free.nrw.commons.UploadTest > testUploadWithDescription[test(AVD) - 7.0] SKIPPED 

fr.free.nrw.commons.WelcomeActivityTest > testBetaSkipButton[test(AVD) - 7.0] FAILED 
	java.lang.AssertionError: Assertion failed
	at fr.free.nrw.commons.WelcomeActivityTest.testBetaSkipButton(WelcomeActivityTest.kt:64)
Tests on test(AVD) - 7.0 failed: There was 2 failure(s).

https://github.com/commons-app/apps-android-commons/pull/5354/files might be a source of inspiration to fix these tests.
@MatheuMa
Copy link

Can I have a try on it?

@nicolas-raoul
Copy link
Member Author

@MatheuMa It is yours, thanks! 🙂

@nicolas-raoul
Copy link
Member Author

@MatheuMa Any progress to share? :-)

@RitikaPahwa4444
Copy link
Collaborator

It's been long, but I'm finally able to run these tests after factory resetting my phone. testBetaSkipButton is running fine on my device, uploadCancelledAfterLocationPickedTest is getting affected by #5461. The list does not open on tapping the list icon at the top-right corner of Nearby.

@RitikaPahwa4444 RitikaPahwa4444 mentioned this issue Jan 30, 2024
Closed
@RitikaPahwa4444
Copy link
Collaborator

With the PR for #5461, I'm able to reproduce this issue for uploadCancelledAfterLocationPickedTest. I would like to give this a try if no one is currently working on it.

@RitikaPahwa4444 RitikaPahwa4444 linked a pull request Feb 3, 2024 that will close this issue
Draft
@sivaraam sivaraam assigned RitikaPahwa4444 and unassigned MatheuMa Feb 3, 2024
@sivaraam
Copy link
Member

sivaraam commented Feb 3, 2024

With the PR for #5461, I'm able to reproduce this issue for uploadCancelledAfterLocationPickedTest. I would like to give this a try if no one is currently working on it.

You could feel free to proceed, Ritika 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RitikaPahwa4444 RitikaPahwa4444

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] 5355: Fix uploadCancelled AfterLocationPickedTest RitikaPahwa4444/apps-android-commons
4 participants
@nicolas-raoul @sivaraam @RitikaPahwa4444 @MatheuMa