Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depictions picker shows labels in OS language instead of app interface language #5341

Open
nicolas-raoul opened this issue Oct 16, 2023 · 5 comments · May be fixed by #5364
Open

Depictions picker shows labels in OS language instead of app interface language #5341

nicolas-raoul opened this issue Oct 16, 2023 · 5 comments · May be fixed by #5364
Assignees
Labels

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Oct 16, 2023

OS in Chinese
App interface in French (in the Commons app's settings)
Labels should be shown in French, but they are actually shown in Chinese:

Screenshot_20231016-184040.png

Same for license selection:
Screenshot_20231016-184554.png

@u7452206
Copy link

Hi, can I take this issue? I find this interesting. Would you have more information to provide? I figure for some languages it doesn't even translate the popup window or it may only be partially translated.

@nicolas-raoul
Copy link
Member Author

@u7452206 It is yours :-)

I suggest testing with OS in Chinese and app in French. Solving for this will most probably fix the issue for all other languages.

for some languages it doesn't even translate the popup window or it may only be partially translated

That's because translations are not complete, which is not really a bug. :-)

The bug here is that even though there are French localizations for "London" and "Creative Commons", they are not shown when the app is set to French.

@u7452206
Copy link

I also found out there are inconsistencies. The Chinese names for London appears in both traditional and simplified.
Screen Shot 2023-10-17 at 16 56 02

@u7452206
Copy link

Could I please know which file do you use to edit language function ? Would love to know what you have tried to solve this issue and work from there.

@nicolas-raoul
Copy link
Member Author

The traditional/simplified inconsistency you found is due to Wikidata, we do not have to worry about it. :-)

I have not tried to solve it. Your task is to find the part of the source code which selects the language for the data filled into those screens.

The license one (step 4) is probably the easiest to find.
The depictions one (step 2) is probably related to a parameter in a Wikidata query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants