Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] A typo in a Basque accent #4287

Open
Txopi opened this issue Dec 26, 2023 · 2 comments · May be fixed by #4323
Open

[BUG] A typo in a Basque accent #4287

Txopi opened this issue Dec 26, 2023 · 2 comments · May be fixed by #4323
Labels
Bug

Comments

@Txopi
Copy link
Contributor

Txopi commented Dec 26, 2023

Describe the bug
When I created issue #1761 four years ago I made a typo. I wrote "Araka" (wrong) instead of "Araba" (right). Please correct this accent in Basque language:

  • Mendebalekoa (Araba + Bizkaia + Gipuzkoako mendebaleko herri batzuk)

To Reproduce
Steps to reproduce the behaviour:

  1. Go to see the profile of a user.
  2. Add Basque language.
  3. List Basque language accents.
  4. See error.

Expected behaviour
It should include the word "Araba", not "Araka".

Screenshots
2023-12-26 20-01-16

Additional context
Araba is part of the Basque Country. It's also an Spanish province with 332.000 residents. When this people use Common Voice they see their region spelled incorrectly.
@Txopi Txopi added the Bug label Dec 26, 2023
@avayyyyyyy
Copy link

Please assign this issue to me!

thank you.

@jessicarose
Copy link
Collaborator

Hello both, thanks you so much @Txopi for flagging this and we agree that fixing this is very important.

@avayyyyyyy we don't tend to assign issues, but there's not a lot of competition for this one if you want to work on it. Looking at the code, it looks like this might be something you could fix by writing a new migration for the database that overwrites the field for the accent "mendebalekoa" associated with the Basque locale ("eu" language code).

You might want to look at this file to see what the migration that brought the typo into the platform looks like, for inspiration!

Mention me in your PR and I'll make sure I look at it right away.

My 2024 goals are to make it easier for folks to contribute to the project. If you do fix this, could you let me know what kinds of documentation or other improvements I could add to my todos that would have made this easier for you.

Thank you both!

@avayyyyyyy avayyyyyyy linked a pull request Jan 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Correct Basque language accent typo avayyyyyyy/common-voice
3 participants
@jessicarose @Txopi @avayyyyyyy