Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog_incremental is set as default when calling changelog from cz bump #883

Open
LuisHenri opened this issue Oct 11, 2023 · 2 comments · May be fixed by #996
Open

changelog_incremental is set as default when calling changelog from cz bump #883

LuisHenri opened this issue Oct 11, 2023 · 2 comments · May be fixed by #996

Comments

@LuisHenri
Copy link
Contributor

LuisHenri commented Oct 11, 2023

Description

cz bump with changelog_incremental = false on pyproject.toml doesn't have any effect when calling cz bump --changelog or cz bump with update_changelog_on_bump = true`.

Steps to reproduce

  1. Define changelog_incremental = false and update_changelog_on_bump = true
  2. Run cz bump

Current behavior

It runs as if changelog_incremental = true.

Desired behavior

Run cz ch without incremental.

Screenshots

image
https://github.com/commitizen-tools/commitizen/blob/9d0878c201c579aaf7d7c0219f19f95897bd01fc/commitizen/commands/bump.py#L272C1-L279C14

Environment

Commitizen Version: 3.10.0
Python Version: 3.8.10 (tags/v3.8.10:3d8993a, May  3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]
Operating System: Windows
@LuisHenri LuisHenri changed the title Good bug title tells us about precise symptom, not about the root cause. changelog_incremental is set as default when calling changelog from cz bump Oct 11, 2023
@Lee-W
Copy link
Member

Lee-W commented Oct 17, 2023

Hi @LuisHenri , thanks for reporting this issue. I've verified this is indeed a valid bug.

@Lee-W
Copy link
Member

Lee-W commented Oct 17, 2023

We'd appreciate it if you're interested in sending us a PR. 🙂 I think this should be an easy and small one. Other than the value change, all we need is adding a few tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants