Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag name validation issue on cz bump --changelog #845

Open
josuerzslzr opened this issue Sep 14, 2023 · 3 comments
Open

Tag name validation issue on cz bump --changelog #845

josuerzslzr opened this issue Sep 14, 2023 · 3 comments

Comments

@josuerzslzr
Copy link

Description

When generating changelog, get_version_tags function from commitizen/changelog.py is validating existing tags as if they were version names with no additional text on them. This behavior conflicts with the feature of customizing tag_format

Steps to reproduce

  1. Use some custom prefixed tag_format in .cz.yaml,
    tag_format: some-project-release-$version

  2. Do initial version commit, bump and generate changelog: cz bump --changelog

  3. Do subsequent fix/feat commit, bump and generate changelog: cz bump --changelog

ER: Version bumped, changelog generated.
AR: Error saying No tag found to do an incremental changelog

Current behavior

get_version_tags function from commitizen/changelog.py is validating tag names as if they where version names, hence it's not able to return existing custom tags, an error appears saying No tag found to do an incremental changelog

Desired behavior

Allow the changelog to generate regardless of tag name custom prefixes, possible solution could be to exclude the tag name prefix when checking with scheme(tag.name)

Screenshots

No response

Environment

Commitizen 3.8.2
Python 3.10.12

@saivenky
Copy link

I'm having the same issue. This would be fixed by #692 (which is linked to issue #519).

@hermanho
Copy link

hermanho commented May 8, 2024

When can fix it? I cannot use commitizen in a monorepo repo and the config tag_format is useless.

@AlexeySanko
Copy link

Looks as great feature for monorepo. Any update on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants