Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on mypy check_untyped_defs = true #1053

Open
4 of 17 tasks
Lee-W opened this issue Apr 4, 2024 · 0 comments
Open
4 of 17 tasks

Turn on mypy check_untyped_defs = true #1053

Lee-W opened this issue Apr 4, 2024 · 0 comments

Comments

@Lee-W
Copy link
Member

Lee-W commented Apr 4, 2024

Description

mypy keeps warning us to use check_untyped_defs. When turning it on, I found out there're a few type annotation issues that could be improved and could potentially be an actual issue.


Possible Solution

Fix the type annotation error/warning one by one

Additional context

list of modules needed to be fixed by 3.21.3

  • commitizen/config/yaml_config.py
  • commitizen/commands/init.py
  • commitizen/config/toml_config.py
  • commitizen/config/json_config.py
  • commitizen/cz/base.py
  • tests/test_factory.py
  • commitizen/commands/changelog.py
  • commitizen/commands/example.py
  • commitizen/commands/commit.py
  • commitizen/git.py
  • tests/test_changelog.py
  • commitizen/cli.py
  • tests/test_cz_customize.py
  • tests/test_cz_conventional_commits.py
  • tests/test_cz_base.py
  • commitizen/commands/info.py
  • commitizen/commands/check.py

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant