Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]Why should the 'control_after_generate' parameter in Ksampler be defined in JavaScript? #3419

Closed
Yoh-Z opened this issue May 7, 2024 · 4 comments

Comments

@Yoh-Z
Copy link

Yoh-Z commented May 7, 2024

Why isn't the 'control_after_generate' parameter defined in NODE's INPUT_TYPES like other parameters, and then handle the seed in Python code? Also, are there any other parameters in the 'widgets_values' of the 'workflow.json' file that are processed in the frontend?If so, is there a unified place to manage them?

@ltdrdata
Copy link
Contributor

ltdrdata commented May 7, 2024

I think it's a result of an old implementation that did not consider things like a 3rd party frontend.

@Yoh-Z
Copy link
Author

Yoh-Z commented May 7, 2024

It seems that "widgets_values" cannot correspond one-to-one with the INPUT_TYPES of the node. Is the issue of unmatchable 'control_after_generate' parameters only present in KSampler, KSamplerAdvanced, and PrimitiveNode?

@ltdrdata
Copy link
Contributor

ltdrdata commented May 7, 2024

It seems that "widgets_values" cannot correspond one-to-one with the INPUT_TYPES of the node. Is the issue of unmatchable 'control_after_generate' parameters only present in KSampler, KSamplerAdvanced, and PrimitiveNode?

It's not just a node problem. Actually control_after_generate is a virtual subwidge of widget which is named seed or noise_seed.
And the PrimtivieNode is a special case.

@Yoh-Z
Copy link
Author

Yoh-Z commented May 8, 2024

It seems like ComfyUI offers a method to save the workflow in API format. Is there still a need for the functionality of Graph2Prompt to support the use of non-API format workflows through API calls in Python? I've already completed a demo for this feature. If it's still needed, I can submit a pull request for it.

@Yoh-Z Yoh-Z closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants