Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comby -review is broken for filepaths containing spaces #356

Open
lehmacdj opened this issue Jan 20, 2023 · 1 comment
Open

comby -review is broken for filepaths containing spaces #356

lehmacdj opened this issue Jan 20, 2023 · 1 comment

Comments

@lehmacdj
Copy link

lehmacdj commented Jan 20, 2023

Describe the bug
When running comby -review to make a change to files where their filepath contains spaces after accepting a change comby fails with the error:

[debug] File to patch: No file found--skip this patch? [y] 1 out of 1 hunks ignored--saving rejects to Oops.rej
,
Error attempting patch, command exited with 1.
Run the command again with DEBUG_COMBY=1 set in the environment for more info.
Press any key to continue, or exit now (Ctrl-C).

Reproducing
Please see this repository that contains a reproduction of the bug, and detailed instructions for reproducing it: https://github.com/lehmacdj/comby-bug-spaces-in-filename-broken

Expected behavior
After accepting the change, the change should be applied exactly as though comby -in-place were used instead.

Additional context
I am using version 1.8.1 of comby which is the latest release

@rvantonder
Copy link
Member

Thanks for the clear reproduction instructions ❤️ . I'll look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants