Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.14.5 Client: ColyseusManager.ConnectToServer is a protected method, contrary to documentation's instruction #147

Open
tonygiang opened this issue May 10, 2021 · 0 comments
Open

0.14.5 Client: ColyseusManager.ConnectToServer is a protected method, contrary to documentation's instruction #147

tonygiang opened this issue May 10, 2021 · 0 comments

Comments

@tonygiang
Copy link

tonygiang commented May 10, 2021 •
edited

The documentation for version 0.14.5 here instructs client developers to connect to server using this command:

ExampleManager.Instance.ConnectToServer();

The usage of the public Instance field implies this command is meant to to called outside of ColyseusManager. But since ColyseusManager.ConnectToServer is a protected method, this is impossible to do. Please either amend the documentation or treat this as a bug.
@tonygiang tonygiang changed the title Colyseus 0.14.5: ColyseusManager.ConnectToServer is a protected method, contrary to documentation Colyseus 0.14.5: ColyseusManager.ConnectToServer is a protected method, contrary to documentation's instruction May 10, 2021
@tonygiang tonygiang changed the title Colyseus 0.14.5: ColyseusManager.ConnectToServer is a protected method, contrary to documentation's instruction 0.14.5 Client: ColyseusManager.ConnectToServer is a protected method, contrary to documentation's instruction May 10, 2021
mitchLucid added a commit to colyseus/docs that referenced this issue May 10, 2021
@mitchLucid
Clarified protected connection call
fee5a13 
Fix to community report: colyseus/colyseus-unity-sdk#147
ConnectToServer is a protected method and therefore cannot be call outside of ExampleManager (or the user's child class)
@mitchLucid mitchLucid mentioned this issue May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonygiang