Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 2 Support? #27

Open
gricey432 opened this issue Oct 25, 2021 · 1 comment
Open

Dropping Python 2 Support? #27

gricey432 opened this issue Oct 25, 2021 · 1 comment

Comments

@gricey432
Copy link

Hey,

I'm just writing up a PR for this repo to propose a new feature.
I've used Python 3 language features, however it looks like the package is documented as supporting Python 2.
Would you require I submit a Python 2 compatible PR or are you open to matching Flask in supporting only 3.6 and newer?

Cheers

@alexprengere
Copy link
Collaborator

Changing the compatibility matrix is a breaking change, so we first need to release a new major version documenting that change, with a clear mention of the new Python versions supported. Ideally we should also modernize the code base (f-strings, annotations, ...). I think Python3.6+ would be a good start (so we effectively drop Python 2.7 and 3.5).

Then we can add Python3-only code. If you do not feel up to it, try to update your code to be "hybrid", supporting both Python2 and Python3 versions (I can help with that if you submit the PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants