Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow starting pisignage from a different directory than where it was checked out #201

Open
raboof opened this issue Jan 2, 2024 · 0 comments

Comments

@raboof
Copy link
Contributor

raboof commented Jan 2, 2024

Currently, pisignage-server expects to be started from the directory where it was checked out / installed: for example, it load the views and public directories relative to the CWD.

I'd propose:

  • view should be immutable and relative to the location of server.js
  • public should be immutable and relative to the location of server.js
  • config/env/all.js should be immutable and moved to config/defaults.js relative to the location of server.js
  • config/env should be configurable, default to $CWD/config/env
  • data should be configurable, default to $CWD/data
  • media should be configurable, default to ../media relative to the location of server.js

If this makes sense I'd be interested in contributing this feature. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant