Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move simplesaml include from /var/ to its location in /vendor #1573

Closed
goetzk opened this issue May 8, 2024 · 1 comment
Closed

Move simplesaml include from /var/ to its location in /vendor #1573

goetzk opened this issue May 8, 2024 · 1 comment

Comments

@goetzk
Copy link

goetzk commented May 8, 2024

Hi Seth,
This is a request for future: I suggest moving Shibboleth.php's simplesamlphp include from /var/ to the installed location under vendor.

kgoetz@L23001:~/source/collectiveaccess_providence$ rgrep var/simplesamlph
app/lib/Auth/Adapters/Shibboleth.php:require_once('/var/simplesamlphp/lib/_autoload.php');

Going by some other imports, that would be replaced with something like this:

require_once(__CA_BASE_DIR__.'/vendor/simplesamlphp/simplesamlphp/lib/_autoload.php');

This would enable installing directly from composer (eg composer require simplesamlphp/simplesamlphp ^2.0) and having CA find the location without any other filesystem fiddling.

I'm not sure if I'll get to this in the near term but thought I'd flag it up and will try to submit a change in future.

@goetzk goetzk changed the title Move to Move simplesaml include from /var/ to its location in /vendor May 8, 2024
goetzk added a commit to medeopolis/providence that referenced this issue May 13, 2024
When installed via composer (the recommended method), simplesamlphp will
be placed under CA's vendor directory.  Installing under
/var/simplesamlphp is only suggested by upstream for source installs.

Closes collectiveaccess#1573.
@goetzk
Copy link
Author

goetzk commented May 13, 2024

I will submit these two PRs related to this issue, once they've been tested a bit more:
https://github.com/medeopolis/providence/tree/dev-php8-composer-graphql-upgrade
https://github.com/medeopolis/providence/tree/dev-php8-simplesaml-path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants