Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manual sorting of selected taxonomy items #74

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

petschki
Copy link
Member

@petschki petschki commented Nov 5, 2019

fixes #71

@coveralls
Copy link

coveralls commented Nov 5, 2019

Coverage Status

Coverage increased (+0.7%) to 46.03% when pulling c99781f on petschki/issue-71 into d5af7b1 on master.

Copy link
Member

@agitator agitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better to me

@petschki
Copy link
Member Author

petschki commented Nov 6, 2019

@malthe maybe you can take a look at this?

@malthe
Copy link
Member

malthe commented Nov 6, 2019

I'm not sure I understand the solution here. It seems like all the code just deleted.

Either a clear analysis of the change should be presented, or a test case that shows the issue and how it's fixed with this change. It's been a while since I touched this code so it's hard for me to understand the correctness of it.

@petschki
Copy link
Member Author

@malthe yes you're right and I'm sorry for this code cut. The problem is, I cannot clearly reproduce the strange behavior of miss-ordered taxonomies. but it happens ... and with this simpler code it doesn't happen again. maybe it's because of python3 ... need to make some more investigations.

@petschki petschki changed the title Ensure Order of taxonomy items Enable manual sorting of selected taxonomy items Nov 26, 2019
@MrTango
Copy link
Contributor

MrTango commented May 27, 2021

@petschki should we merge this or is there anything more to do?

@petschki
Copy link
Member Author

There is a confusing ordering problem in a project of @agitator and me and this PR tries to fix it but AFAIK there are still some edge cases ... so not ready to merge for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taxonomy order is not reflected in widget
5 participants