Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taxonomy data in SearchableText index ? #55

Open
bsuttor opened this issue Dec 5, 2017 · 4 comments
Open

Add taxonomy data in SearchableText index ? #55

bsuttor opened this issue Dec 5, 2017 · 4 comments

Comments

@bsuttor
Copy link
Member

bsuttor commented Dec 5, 2017

Hello,

Here is my use case,
I added taxonomy on a dexterity portal_type "organization" to add type of organization (butcher, plumber, ...) and I would like to have a list of all butcher when I make a "butcher" search into Plone seach input.

I see in taxonomy than "id" of data is already registered into a catalog index (which is added when a taxonomy is created), but I'm not able to find 1gfkx7fgti easily with Plone search bar.

So maybe it would be great to add data (eg butcher) into SearchableText index to be able to find it when a user use Plone search bar ?

Do you think it's a good idea ? Do you know other/better way to do that ?

@vincentfretin
Copy link
Member

I'm against indexing it by default, it can add a lot of noise in SearchableText. And you should index all the translations of the terms used for your content? What about when you modify a translation of the term? You need to reindex all your contents in this case.

@vincentfretin
Copy link
Member

Why don't you use a specific filter or a facetednav in your project?

@bsuttor
Copy link
Member Author

bsuttor commented Dec 8, 2017

Thank you for your reply,

I really would use Plone search bar (or in a facetednav search bar) to find all content related to a taxonomy. It seems (to me) very logical to be able to find content related to a taxonomy in Plone search bar.
It could be an option of control panel to index taxonomy "data", and yes, if a translation change, all contents tagged with old translation should be re-tagged.

It could also override plone.app.search browser view, but I think search would be to slow if it search also in taxonomy (transform taxonomy id to translated term) during a Plone search.

I could also replace Plone search view by a factednav search view.

@malthe
Copy link
Member

malthe commented Jul 12, 2018

It seems pretty easy to make it optional, i.e. register a searchable text indexer thingy and then just plug in terms based on whether this option is enabled – per taxonomy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants