New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation message spam #143
Comments
Hi Grant, glad you're enjoying the SDK! The 2nd link you gave should be fairly simple to refactor, just replace For the third link you don’t need to refactor anything, just pass in a configuration object instead of using the default option when creating your worker. The first link requires a pretty big refactor if I remember right, I’ll let @antstorm chime in on how to approach that one. |
@gshively11 agree with what DeRauk said above. The first link is definitely a bigger refactor project, but should also be doable. I think the best approach there is to make payload converters ( We can also avoid breaking changes by having one or two places where we fallback onto default configuration if nothing else is provided, but it should be at the top level and would result in minimal output noise. I'm happy to assist you with the PR or I can take a look at it next week in case you feel like it might be a bit too much. |
@gshively11 I might have some time to pick it up this week. Will ping you on the PR |
For other travelers wondering how to silence this, I ended up not caring about this message (it has been 'deprecated' for over 2 years now, afterall). I added this to my
Voilá - no more warnings. (I know this is bad, I just couldnt take it anymore) |
Hey folks, I'm just dipping my toes into temporal and this SDK is a lifesaver, thanks for open sourcing it!
I'm playing with temporal locally and I'm seeing a lot of deprecation message spam when running workflows/activities:
This appears to be due to this line.
Which is still used in multiple spots in the codebase:
Do you have any guidance for removing the deprecated code? I'm happy to attempt a PR, but wanted to check with the maintainers first.
The text was updated successfully, but these errors were encountered: