Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Framegear URL field is too short #319

Open
briandoyle81CB opened this issue May 2, 2024 · 5 comments
Open

Feature Request: Framegear URL field is too short #319

briandoyle81CB opened this issue May 2, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@briandoyle81CB
Copy link

Describe the solution you'd like

It should show the entire url. Some frames depend on long urls or query params that aren't visible when testing.

Describe alternatives you've considered.

No response

@Zizzamia Zizzamia added enhancement New feature or request good first issue Good for newcomers labels May 2, 2024
@MukulKolpe
Copy link

Hey @briandoyle81CB, @Zizzamia can I work on this issue?

@Zizzamia
Copy link
Contributor

Zizzamia commented May 3, 2024

@MukulKolpe all yours :)

@cnasc
Copy link
Contributor

cnasc commented May 3, 2024

I wonder if instead of growing the URL field like in #321, it would make sense to add the URL the frame response came from to the validation results? Thinking of this for two reasons:

  1. Chances are when debugging the frame, you're going to look at the validation results. If you're already focused on that part of the screen, it's a better UX to have the relevant info there.
  2. I think when we expand the input itself, the layout looks a little weird

@briandoyle81CB @bansalgautam @Zizzamia thoughts on this?

@bansalgautam
Copy link
Contributor

bansalgautam commented May 3, 2024

Yeah, I think that would provide a better UX. I tried it, here is the result
image

@cnasc

@cnasc
Copy link
Contributor

cnasc commented May 3, 2024

@bansalgautam nice! I would just follow the format of the other cells with the key on top then the value on the bottom but other than that LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

5 participants