Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to define appLogoUrl #610

Open
homeyong opened this issue Aug 5, 2022 · 6 comments
Open

Bug: Unable to define appLogoUrl #610

homeyong opened this issue Aug 5, 2022 · 6 comments
Assignees
Labels
state: in progress type: bug Something isn't working

Comments

@homeyong
Copy link

homeyong commented Aug 5, 2022

Describe the bug

Unable to define appLogoUrl for coinbase browser extension

Steps

  1. Go to https://codesandbox.io/s/web3modal-demo-forked-obbuf5?file=/src/providerOptions.js.
  2. Define appLogoUrl, in my example it is twitter.ico
  3. Refresh the sandbox browser
  4. Click on the Connect > Select Coinbase > noticed that the icon does not change to twitter.
    image

Expected behavior

The Icon should in the coinbase extension show the logo that defined in appLogoUrl.

Version

3.0.1

Additional info

No response

Desktop

No response

Smartphone

No response

@homeyong homeyong added the type: bug Something isn't working label Aug 5, 2022
@jackromo888

This comment was marked as spam.

@pchy10
Copy link

pchy10 commented Sep 28, 2022

Any progress on this? I am also getting a similar kind of error.

Currently, I am seeing a broken image while it Is showing the user permission window. I am using the following code to initialize the CoinbaseWalletSDK:

import ethers from "ethers";
import CoinbaseWalletSDK from "@coinbase/wallet-sdk";

const CHAIN_ID = 80001;
// const RPC_URL = ...
// ...
const coinbaseWallet = new CoinbaseWalletSDK({
  appName: "Affine",
  appLogoUrl: "/favicon.io"
});

const ethereum = coinbaseWallet.makeWeb3Provider(RPC_URL, parseInt(CHAIN_ID, 16));

const provider = new ethers.providers.Web3Provider(ethereum);
// ...

image

But after the connection has been made, the Dapp Connections on the extension is showing the title & favicon of that route:

image

Update

The version I am using is ^3.5.3 for @coinbase/wallet-sdk and ^5.6.5 for ethers.

@immunity20
Copy link

immunity20 commented Nov 30, 2022

Any update for fixing the empty image?
@petejkim You need to update your Coinbase Extension.

You try to display website's favicon.ico but instead of <img src="favicon_url" /> you do <img alt="favicon_url" />

image

@gareys-cb
Copy link
Contributor

Hey! Thanks for reaching out.

If you are still working on this, please try the following:

  1. Ensure that your appLogoUrl is a complete URL, not a relative path. i.e. https://mysite.com/logo.png
  2. Provide a browser supported image filetype such as .png or .jpg. See the supported filetypes.

We will update our docs to reflect these requirements. Sorry for the confusion.

@bangtoven bangtoven added state: investigation Pending investigation and removed state: backlog labels Jan 12, 2023
@pchy10
Copy link

pchy10 commented Feb 6, 2023

Hey! Thanks for reaching out.

If you are still working on this, please try the following:

  1. Ensure that your appLogoUrl is a complete URL, not a relative path. i.e. https://mysite.com/logo.png
  2. Provide a browser supported image filetype such as .png or .jpg. See the supported filetypes.

We will update our docs to reflect these requirements. Sorry for the confusion.

@gareys-cb I used an external URL as mentioned, but still seeing the same issue. For reference, I am using this URL as appLogoUrl value - https://cdn.affinedefi.com/affine/logo-512x512.png

@Hlllllllii
Copy link

Hlllllllii commented Feb 6, 2023 via email

@coinbase coinbase deleted a comment Feb 26, 2023
@coinbase coinbase deleted a comment Feb 26, 2023
@bangtoven bangtoven added state: in progress and removed state: investigation Pending investigation labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: in progress type: bug Something isn't working
Development

No branches or pull requests

8 participants