Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: SmartWallet - Allow owners to be initialized implicitly at time of setup #1275

Open
Silur opened this issue May 6, 2024 · 1 comment
Labels
type: enhancement New feature or request

Comments

@Silur
Copy link

Silur commented May 6, 2024

Is your feature request related to a problem? Please describe.

While the deployed smart-contracts support the whitelisting of additional owners besides the signer account, the SDK itself does not provide a way to clone the contract using the factory with the owners parameter.

Describe the solution you'd like

export const coinbaseWalletSdk = new CoinbaseWalletSDK({
  appName: "An Awesome App",
  appChainIds: [84532],
  owners: [address1, address2] // would be nice to have this here
});

Describe alternatives you've considered

Currently, approving an additional owner on top of the first-time signer has to take place in a separate transaction, which is contrary to the general "easy to onboard", "set up in 10 seconds" narrative.

Additional context

No response

@Silur Silur added the type: enhancement New feature or request label May 6, 2024
@Silur Silur closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@Silur Silur reopened this May 6, 2024
@Silur Silur changed the title Feature Request: Allow owners to be initialized implicitly at time of setup Feature Request: SmartWallet - Allow owners to be initialized implicitly at time of setup May 6, 2024
@wilsoncusack
Copy link

Thanks! Is the idea here that keys.conbase.com still creates the account, and you can pass owners? Or you want a full SDK for interacting with the smart contracts directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Development

No branches or pull requests

2 participants