Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple scan types, specified by flag #76

Open
codingo opened this issue Oct 23, 2018 · 4 comments
Open

Multiple scan types, specified by flag #76

codingo opened this issue Oct 23, 2018 · 4 comments

Comments

@codingo
Copy link
Owner

codingo commented Oct 23, 2018

Along with the change #74 the user should be able to specify additional, modified scans that they can launch at command line.

So, for example, if:

--scantype "codingo-hackthebox"

Was run then the scan found under "codingo-hackthebox" in the scans object in config.json would be used. If nothing was specified then the object "default" would be used.

@CrimsonK1ng
Copy link
Contributor

I can start working on this issue.

@codingo
Copy link
Owner Author

codingo commented Oct 4, 2019

That would be great, if you can put a PayPal in your pr I'd love to send you a token of thanks as well.

@CrimsonK1ng
Copy link
Contributor

Just wanted to check before I do any significant changes, but what would you like the scan default to be? Currently I would have an empty default object under scan. Then users would add their own scans which you can then provide as an argument on the command line as ---scantype my-scan. Is that along the lines of what you were thinking? Also thanks, I like this project so I wanted to help.

scans: {
   'default': {},
   'my-scan': {
        'description': 'does my scan',
        'commands': [
             "scan1",
             "scan2",
             ...
        ]
    }
}

@codingo
Copy link
Owner Author

codingo commented Oct 5, 2019

I like this approach, maybe add a couple of examples to help guide users, but the one labelled default would be the one used if no flags are passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants