Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

撰写 README #6

Open
sinkcup opened this issue Oct 23, 2021 · 2 comments
Open

撰写 README #6

sinkcup opened this issue Oct 23, 2021 · 2 comments
Assignees

Comments

@sinkcup
Copy link
Member

sinkcup commented Oct 23, 2021

codecov badge 要放上 https://app.codecov.io/gh/Coding/coding-sdk-php/

目前覆盖率 100% !

其余参考:https://github.com/aws/aws-sdk-php

@sinkcup sinkcup self-assigned this Oct 23, 2021
@sinkcup
Copy link
Member Author

sinkcup commented Oct 24, 2021

需要写使用例子,所以打 tag,尝试安装调用,发现 依赖注入自动绑定的方式 没法传递构造参数:

public function handle(Iteration $iteration)
{
  $iteration->create();
}

所以目前的写法不对:

class Iteration
{
    private Core $core;

    public function __construct(string $token, Core $core = null)
    {
        $this->core = $core ?? new Core($token);
    }

sinkcup added a commit that referenced this issue Oct 24, 2021
@sinkcup
Copy link
Member Author

sinkcup commented Oct 24, 2021

调用报错:The goal must be a string. #8

看来应该在本地安装调试,而不应该这么自信的直接打 tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant