Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

95 Weekday: Handles 1582 dates incorrectly #546

Open
stevebosman opened this issue Jan 30, 2022 · 4 comments
Open

95 Weekday: Handles 1582 dates incorrectly #546

stevebosman opened this issue Jan 30, 2022 · 4 comments

Comments

@stevebosman
Copy link
Contributor

The following line in the original code leads to an error if dates before 1582 are supplied (which is fine)
290 IF Y-1582 <0 THEN 1300

However it means the day of week calculation is performed on days in 1582, but before 15 October 1582 (the date the Gregorian calendar started).

I think the test should be changed to check that the supplied date is on or after 15 October 1582.

@stevebosman
Copy link
Contributor Author

I am currently looking at tidying up the Javascript implementation, but I am unsure whether I should unilaterally fix this on one implementation.

@coding-horror
Copy link
Owner

sure, if it is a bug in the original code please put a note in the readme.md in the game folder!

@coding-horror
Copy link
Owner

One of my todo items is to add a "translator / port notes" section to the readme.md of each game..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@stevebosman @coding-horror and others