Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Blur and Gradient optional! #29

Open
eqaderi opened this issue Sep 17, 2016 · 3 comments
Open

Make Blur and Gradient optional! #29

eqaderi opened this issue Sep 17, 2016 · 3 comments

Comments

@eqaderi
Copy link

eqaderi commented Sep 17, 2016

Hi Michał,

This library is very awesome, animations are smooth and they look very fluent and beautiful. I think to make it much more better it would be great if you could make the Blur and Gradient effects optional, so that if a project overall styles requires the counter to be plain and simple without those fancy effects it would be possible and there would be no need to turn into other libreries like odometer.js ...

Do you think you will enable these as options?

@coderitual
Copy link
Owner

Hi! The main reason I didn't use odometer.js and created this library was lack of those effetcs. I consider making them optional though, but in different way than by providing boolean flags.

@fredrikekelund
Copy link

For my use case, with 6 instances of bounty running in parallel on a single page, Safari on iOS actually couldn't handle the motion blur effects (the page crashed). Given that the number animation still looks very appealing without the motion blur, I think it would make sense to be able to toggle that somehow. Is there a particular reason that you would rather avoid boolean flags?

@coderitual
Copy link
Owner

@fredrikekelund my idea was to allow compose motion effects rather than configure them, but at this moment API is more oriented toward configuration (at least without ground rework of the API, which may appear the earliest in the next version.). Are you happy to work on such PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants