Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version 4.0.1 of JGit #3

Merged
merged 1 commit into from Aug 27, 2015

Conversation

tareksha
Copy link
Contributor

Move from version 2.3 to version 3.7.1 of JGit as a preparation for integrating JGit into the Git Extension of Che.

Signed-off-by: Tareq Sharafy tareq.sharafy@sap.com

@skabashnyuk
Copy link
Contributor

Can you check the status of git server with compatibility to 3.7.1?

@lextiz
Copy link

lextiz commented Aug 27, 2015

git-server is compatible with JGit 3.7.1.

@tareksha
Copy link
Contributor Author

hi @skabashnyuk,
The jump from JGit 3.7.1 to 4.0 is minimal compared to the jump from 2.3 to 3.7.1, with no effects on the APIs we use (mostly stability and performance improvements). Maybe we should just skip 3.7.1 right to 4.0? Eclipse Mars is bundles with 4.0 which means it is stable for production use.

@skabashnyuk
Copy link
Contributor

I need to make sure git server functionality remain the same. I'm ok with 4.0 also.
We can start with this one

<dependency>
    <groupId>org.eclipse.jgit</groupId>
    <artifactId>org.eclipse.jgit</artifactId>
    <version>4.0.1.201506240215-r</version>
</dependency>

If you sure it's 100% source code compatible with che code.
When I will organize integration testing here. And when I will aprove this change
WDYT?

@tareksha
Copy link
Contributor Author

Seems logical to me. I'll update the pull request to contain 4.0.1.
Do you have a rough time estimate for when will this go through in case of positive results?

Change-Id: Ifc5b3c2d44a1276c978e8fc6d776ccade5dcdc74
Signed-off-by: Tareq Sharafy <tareq.sharafy@sap.com>
@tareksha tareksha changed the title Upgrade to version 3.7.1 of JGit Upgrade to version 4.0.1 of JGit Aug 27, 2015
@skabashnyuk
Copy link
Contributor

No ETA for this time.

skabashnyuk added a commit that referenced this pull request Aug 27, 2015
@skabashnyuk skabashnyuk merged commit e3f3595 into codenvy-legacy:master Aug 27, 2015
@skabashnyuk
Copy link
Contributor

Passed my local test. If nightly test will fail I'll rollback this changes.

@tareksha tareksha deleted the upgrade_jgit_to_3.7.1 branch November 19, 2015 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants