Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of column height #2

Open
theryankelly opened this issue Feb 10, 2015 · 3 comments
Open

Alignment of column height #2

theryankelly opened this issue Feb 10, 2015 · 3 comments

Comments

@theryankelly
Copy link
Member

Would like to have three columns relatively same height because they are all the same total amount of money.

Is it possible to align all three columns using padding/white space? The padding that is added to the third column creates an illusion that the funds are increasing when the total is the same for all three columns. Fixing the height seems to lose many of the smaller categories.

@nelsonri72
Copy link
Member

I agree. It was an issue already brought up. Perhaps it may default to no padding to appear equal but when selected it may be padded and expand?

@jamesrhaley
Copy link
Member

This particular issue is how the plug in calculates the spacing. This is
pretty much a feature addition to that plugin that would be required. The
plug in can be found here.

https://github.com/d3/d3-plugins/tree/master/sankey

While I was planning on overhauling this plugin after I finished some
courses, If there was someone in the Code for America world that wished
to contribute I would be happy to collaborate. I am familiar with the
section of the code that would need to be changed. We could fork it and go
from there.

On Tue, Feb 10, 2015 at 5:51 PM, Nelson Rocha notifications@github.com
wrote:

I agree. It was an issue already brought up. Perhaps it may default to no
padding to appear equal but when selected it may be padded and expand?


Reply to this email directly or view it on GitHub
#2 (comment)
.

theryankelly added a commit that referenced this issue Feb 20, 2015
@Frymasterspeck
Copy link
Member

Regardless of whatever fix we eventually work out, I think we need to add some explanatory text IMMEDIATELY. I think a simple sentence should do it. Please check out the Github repo link issue where I will pick up this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants