Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Change Functionality on Manage Tenants Page #439

Open
10 tasks
DaveTrost opened this issue Nov 18, 2020 · 3 comments
Open
10 tasks

Bulk Change Functionality on Manage Tenants Page #439

DaveTrost opened this issue Nov 18, 2020 · 3 comments

Comments

@DaveTrost
Copy link
Member

DaveTrost commented Nov 18, 2020

Purpose
Add functionality so admins can apply bulk updates for the JOIN staff member(s) assigned to a tenants

  • On page 8 of the FIGMA designs, we can see a collapsed grey bar above the tenants table
  • On page 29, we see that the bar expands when one of more tenants are selected with the checkboxes next to their names. The bar is called "Update" and enables users to assign a JOIN staff member to multiple tenants at once.

Proposed Solution

  • Build the collapsible component. Use a react-search-panel element with 'chips' and 'multiple' for the JOIN Staff selection box. This will allow the component to support the assignment of multiple JOIN staffers to a tenant/s
  • Sensitize collapsed/expanded state based on tenant selection (i.e. the checkboxes)
  • Disable the "Save" button on initial render. Enable it when 1 or more staff are selected.
  • When "Save" is clicked, send all updates to the backend. Use a PATCH request to the endpoint: /api/staff-tenants. The body of the request should look like this (per Create staff_tenant resource #443):
{
    staff: [<int:staff_id>, ...],
    tenants: [<int:tenant_id>, ...]
}
  • After the API call is complete, refresh the view with another API call - GET /api/tenants

Please make sure you've attempted to meet the following coding standards

  • Code builds successfully
  • Code has been tested and does not produce errors
  • Code is readable and formatted
  • There isn't any unnecessary commented-out code
  • There aren't any unnecessary commits or files changed (shouldn't touch the /stashed folder unless the issue requests it)

Mockup Screenshot or Page Number
See pages 8 and 29 of the FIGMA designs

@DaveTrost DaveTrost added this to To do in Sprint Winter 2021 via automation Nov 18, 2020
@keppel2 keppel2 self-assigned this Jan 30, 2021
@keppel2
Copy link

keppel2 commented Jan 30, 2021

I'll look at this.

@DaveTrost
Copy link
Member Author

@keppel2 - Can you update this one? Is it In Progress? Did you get busy on something else?
I'm looking to get tickets out of the "To Do" (unassigned) column and into "In Progress" when someone is working on it. And I'm looking to remove assignees when a ticket isn't actively being worked so others can contribute.

@keppel2 keppel2 removed their assignment Feb 22, 2021
@Protopaco
Copy link
Contributor

Taking a quick look at this, the edit tenants page has bulk change functionality for archiving tenants, that doesn't show on the FIGMA.

Screen Shot 2021-04-14 at 8 25 52 PM

Do we have a plan on how to add this functionality without cluttering the header? We could add a button next to the Archive Tenants button that would allow for this same functionality without adding more confusion to the existing architecture. Something akin to the Assign Join Staff input on the Add Tenant page.

Screen Shot 2021-04-14 at 8 31 37 PM

I'd be happy to take a run at this and sketch something out if thats cool.

@Chris-Boe Chris-Boe added the on hold Not going to do this quite yet label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants