Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Google+ API to Local Auth or Google Identity #76

Open
jberns opened this issue Jan 8, 2019 · 1 comment
Open

Change Google+ API to Local Auth or Google Identity #76

jberns opened this issue Jan 8, 2019 · 1 comment

Comments

@jberns
Copy link
Contributor

jberns commented Jan 8, 2019

https://developers.google.com/identity/

@jberns jberns added the to do label Jan 8, 2019
@lrm25
Copy link

lrm25 commented Jan 14, 2019

It's Luke from last Monday. I looked at the issue a bit. Google provides migration instructions here:
https://developers.google.com/identity/sign-in/web/quick-migration-guide

So it looks like the changes required would be:

Local auth:

  1. Notify users that they won't be able to use google to sign in anymore, and tell them to use local authentication
  2. Remove any google sign-in buttons on the client pages
  3. Remove a bunch of dead code

Google Identity:

  1. Change the Google+ login buttons to Google Identity ones, as described in the link
  2. Replace the OAuth-handling code on H4H's client pages and server with Google's token-handling code

The latter is definitely more work and more learning, but the least annoying to users. I'd go with the latter just because of the lack of inconvenience. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants