Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect users to login page when they are not authenticated #864

Open
seankwilliams opened this issue Oct 26, 2023 · 3 comments
Open

Redirect users to login page when they are not authenticated #864

seankwilliams opened this issue Oct 26, 2023 · 3 comments

Comments

@seankwilliams
Copy link
Collaborator

If you are logged out and visit pages like https://comrad.kgnu.org/reporting/charting, you see the page but cannot do anything.

Right now, the app only redirects users to the login screen if they are unauthenticated when an API request happens. It should redirect users to the login page when directly visiting pages like https://comrad.kgnu.org/reporting/charting

@kmid5280
Copy link
Contributor

@seankwilliams Do you supposed this needs to be fixed by adding some sort of "isLoggedIn" conditional on each affected page, or do you have other suggestions?

@seankwilliams
Copy link
Collaborator Author

@kmid5280 I am not sure. I'd look around to see if there are any best practices for other apps like Comrad, that are running with a separate static asset server and API server.

@seankwilliams
Copy link
Collaborator Author

@kmid5280 Or rather, running those on different ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants