Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapWithAMarker and MapCard components should be separated or modified #464

Open
Aaron-Lathrop opened this issue Mar 19, 2019 · 0 comments
Open

Comments

@Aaron-Lathrop
Copy link
Contributor

Items to consider refactoring:

  1. MapWithAMarker should be made a separate component so it can be easily inserted into different contexts. For example, adding the component to the RenderNewCampaign component for issue Campaign- creator #419 requires no title and a different size
  2. MapWithAMaker should have a defaultCenter of the provided latLng or the center of Denver (39.7392, -104.9903). This ensures that the map marker will always be in the center of the map so users can see exactly where the searched address is.
  3. MapWithAMarker should be zoomed in more so users can see the area searched and not just a broad view of the Denver Metro area. Suggested zoom value is 15.
  4. Alternatively, MapCard should have additional options for styling so that it can be used in more than a single context. Additional parameters to include could be: displayTitle(Boolean), containerElement(JSX). The optional containerElement parameter could have a default of the current value found in the MapCard component and allow developers to specify their own if they wish.

The above suggestions should help make the MapCard component more reusable to developers and more useful to users.

@Aaron-Lathrop Aaron-Lathrop changed the title MapCard component needs to be refactored MapWithAMarker and MapCard components should be separated or modified Mar 19, 2019
@wdoug wdoug added this to Inbox in codefordenver/Circular Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant