Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig file to normalize formatting #168

Open
doub1ejack opened this issue Dec 7, 2019 · 1 comment
Open

Add .editorconfig file to normalize formatting #168

doub1ejack opened this issue Dec 7, 2019 · 1 comment
Assignees
Labels
code health Improvements to codebase to help devs difficulty: low Pretty straightforward stuff
Projects

Comments

@doub1ejack
Copy link
Member

Currently there is no formatting guidance on this project so our PRs see a whole lot of distracting whitespace changes. We've looked at using Prettier, but the implementation can vary between developers.

Let's try using the same .editorconfig that the GreenUp project uses (https://github.com/codeforbtv/green-up-app/blob/master/.editorconfig). Feel free to make any personal tweaks you prefer, or ask the #money-on-my-mind channel for their preferences.

Goals:

  1. VS Code should be able to recognize the .editorconfig file and use it's formatting rules
  2. Try to find a way to apply the .editorconfig rules recursively throughout the entire project
@doub1ejack doub1ejack created this issue from a note in CVOEO (To do) Dec 7, 2019
@doub1ejack doub1ejack added code health Improvements to codebase to help devs difficulty: low Pretty straightforward stuff labels Dec 7, 2019
@pphelps28 pphelps28 self-assigned this Dec 8, 2019
@pphelps28 pphelps28 moved this from To do to In progress in CVOEO Dec 8, 2019
@pphelps28
Copy link
Collaborator

Made a bit of a mess with the pull request for this one, sorry. I found the proper plugin to implement the .editorconfig format moving forward, but still need to apply it recursively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Improvements to codebase to help devs difficulty: low Pretty straightforward stuff
Projects
CVOEO
  
In progress
Development

No branches or pull requests

2 participants