You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
with using for each class given that they implement IDisposable, and also using the var keyword.
Current Behavior
The examples in both the README file and the Wiki section don't use using so I wonder if that's the best use case, and if not then why do the classes implement IDisposable. Also I think the documentation should be updated to use var keywords.
Possible Solution
Update documentation in README and Wiki with using and var. Current code samples could still be there in case somebody is using the package with a very old .NET version that doesn't support them. I'm willing to make a PR for this :)
The text was updated successfully, but these errors were encountered:
There's no specific reason, why the using statements aren't part of the documentation. The documentation just wasn't updated in this particular aspect. So feel free to send in a PR.
Type of
[ ] Bug
[x] Question (e.g. about handling/usage)
[ ] Request for new feature/improvement
Expected Behavior
I'm using the package as follows:
with
using
for each class given that they implementIDisposable
, and also using thevar
keyword.Current Behavior
The examples in both the README file and the Wiki section don't use
using
so I wonder if that's the best use case, and if not then why do the classes implementIDisposable
. Also I think the documentation should be updated to usevar
keywords.Possible Solution
Update documentation in README and Wiki with
using
andvar
. Current code samples could still be there in case somebody is using the package with a very old .NET version that doesn't support them. I'm willing to make a PR for this :)The text was updated successfully, but these errors were encountered: