Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Font weights #52

Open
mpospese opened this issue Nov 1, 2022 · 0 comments
Open

Correct Font weights #52

mpospese opened this issue Nov 1, 2022 · 0 comments
Labels
bug Something isn't working in progress Someone is working on this issue

Comments

@mpospese
Copy link
Contributor

mpospese commented Nov 1, 2022

Intro

The Typography.FontWeight enum maps from a font weight to a number (1-999) using the styles found here

We have the values for thin and ultralight swapped.
We're also missing a value for extraBlack (950), aka ultraBlack

Task

  1. Correct thin and ultraLight definitions (swap values 100 and 200)
  2. Add an extraBlack (950) value

Discussion

Need to think about whether we wish to rename any of the existing values. The current heavy for 800 is problematic because heavy traditionally means 900.

@mpospese mpospese self-assigned this Nov 1, 2022
@mpospese mpospese added bug Something isn't working in progress Someone is working on this issue labels Nov 1, 2022
@mpospese mpospese removed their assignment May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress Someone is working on this issue
Development

No branches or pull requests

1 participant