Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with other addons #2255

Open
bottleblue opened this issue May 9, 2024 · 6 comments
Open

Conflicts with other addons #2255

bottleblue opened this issue May 9, 2024 · 6 comments
Assignees
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Riddle up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@bottleblue
Copy link

bottleblue commented May 9, 2024

Firefox 125.0.3
Improved YT 4.805

This is a good addon but it causes issues with other addons:

Hide YouTube Fullscreen Controls
I know this one is probably unavoidable since Improved YT has its own feature for hiding/showing the controls but it's still annoying and I like using Hide YT better since you can hide/show the controls on the fly without having to change it in options like Improved YT.

If you have ImprovedYT enabled Hide YT stops working after you pause/play video.
In Improved YT I had Hide Player Controls bar set to off. In Hide YT options, enable Mouse Interaction, Preset - Hide when mouse is at border

Play the video, move your mouse to the right or left border. The control should hide. After pausing/playing the video the control bar will become visible again and you need to move your mouse to the border to activate it again.

Gesturefy
Rocker gestures won't work with Improved YT.
Open Gesturefy options, Extras, enable Rocker gestures, for left and right mouse click open the command list; scroll down a little and select Scroll to Top and Bottom for left and right mouse click respectively.
Try and active the rocker gestures on youtube page. Nothing happens.

ContextSearch web-ext
When opening a new tab using the Quick Menu it causes the youtube page to scroll to the top.
Open ContextSearch settings, Quick Menu, scroll down to Opening/Mouse. I selected Hold Right mouse button.
Highlight a word in the youtube comments, hold right mouse button to open quick menu, click a search engine like google.

@bottleblue bottleblue added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels May 9, 2024
@ImprovedTube ImprovedTube added the Rare use-case? Niche or just for fun? (Or if it is currently used, then we predicted/scheduled a successor) label May 9, 2024
@ImprovedTube
Copy link
Member

ImprovedTube commented May 9, 2024

hi & thanks @bottleblue (i put these three in opposite order)

The 1rd one comes under MIT license so we should make a merged feature? @nralbrecht https://github.com/nralbrecht/youtube-hide-controls/issues

2nd: Unfortunately even with 92000 daily users, i can't assume much intersection in user base. - Yet maybe it applies more often and we can avoid catching clicks first by some click event listener?

( 3rd: Yet I only know YouTube scrolls up when closing the video description. )

@ImprovedTube ImprovedTube added Completition / Revision Rethink, complete, improve, tweak our feature or structure. Riddle and removed Bug Bug or required update after YouTube changes Rare use-case? Niche or just for fun? (Or if it is currently used, then we predicted/scheduled a successor) labels May 9, 2024
@ImprovedTube ImprovedTube added this to the Hard/tricky(?) milestone May 9, 2024
@bottleblue
Copy link
Author

  1. That would be nice but if it conflicts with the other addons I would probably still have to stop using it.

  2. Maybe it could be an easy fix.

  3. I set video description to Normal and Hidden but it still doesn't respond to the rocker gestures.

@ImprovedTube
Copy link
Member

With nothing set, ImprovedTube shouldn't conflict with 1. 🤔

@bottleblue
Copy link
Author

What do you mean nothing set? You mean when Hide Player Controls bar is set to off?

@ImprovedTube
Copy link
Member

hi! @bottleblue yes!

@bottleblue
Copy link
Author

bottleblue commented May 18, 2024

I still have problems with Hide YT Fullscreen even with the latest update. I should have clarified though in my original post, when you pause/play with the spacebar it will cause the control bar to reappear. Although it also happens if I pause/play with mouse even if the cursor is inside the trigger distance.

I see you fixed the problems with Gesturefy and ContextSearch. Thank you for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Riddle up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: No status
Development

No branches or pull requests

2 participants