Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Blocklist button doesn't work for me, let me edit manually (plus import/export) #2236

Open
cain-dev opened this issue May 4, 2024 · 8 comments
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@cain-dev
Copy link

cain-dev commented May 4, 2024

No need for too much explanation, it's an amazing feature, the one i use the most but the button almost never works, anything that youtube updates then it stop working, but at least it's blocking things just fine for me (yet).

My 2 cents to keep it working a little bit more? Make it field so i can manage it with a .txt file or something, import/export and stuff so i can manually put everything there to blocklist.

@cain-dev cain-dev added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels May 4, 2024
@ImprovedTube
Copy link
Member

hi @cain-dev thank you!

@raszpl
Copy link
Contributor

raszpl commented May 4, 2024

I rewrote and fixed up blocklist #2098 https://github.com/raszpl/YouTube-Extension/tree/BLOCKLIST in theory its ready to be merged, I just didnt get around to testing it too extensively.

@cain-dev
Copy link
Author

cain-dev commented May 7, 2024

Is export/Import a possibility?

@raszpl
Copy link
Contributor

raszpl commented May 7, 2024

No native support available, but this is how example (blocked content is some of my favorite, its just for a test) data looks like:

JSON.stringify(ImprovedTube.storage.blocklist)

{"channels":{"mustie1":{"preview":"https://yt3.googleusercontent.com/ytc/AIdro_lvexMnv3YQ3w6GC5tAJgH3rougPNODCB7BLMwTc99UWA=s900-c-k-c0x00ffffff-no-rj","title":"Mustie1"}},"videos":{"AEm-2giH_zw":{"title":"Flash photography used to be pretty wild"},"DTsQjiPlksA":{"title":"Old HVAC industry practices are holding us back and costing us money. But we can fix it."},"E3p_Cv32tEo":{"title":"The step-by-step, mechanical logic of old pinball machines"},"MFEHFsO-XSI":{"title":"Why Heat Pumps are Immensely Important Right Now"},"QvY6taoAeM8":{"title":"NAJWIĘKSZY FIAT LAT 70. #shorts #fiat #klasyk #fiat130"},"RSTNhvDGbYI":{"title":"Old-fashioned rice cookers are extremely clever"},"_hAuKtoRxJI":{"title":"HVAC professionals aren't sizing equipment appropriately [condensed version]"}}}

@ImprovedTube ImprovedTube added Completition / Revision Rethink, complete, improve, tweak our feature or structure. and removed Bug Bug or required update after YouTube changes labels May 14, 2024
@RimTimTagi
Copy link

It seems that the block button no longer appears anywhere onsite after this.

If the video has already been added, the blocking function itself works as fine as before; adding an entry manually and importing it also produces a block.

@raszpl
Copy link
Contributor

raszpl commented May 15, 2024

block button no longer appears anywhere onsite after this.

you dont see those ?
video
channel

@RimTimTagi
Copy link

RimTimTagi commented May 17, 2024

Not anymore after the update.

Uncaught TypeError: Cannot read properties of undefined (reading 'videos')

@ImprovedTube
Copy link
Member

Uncaught TypeError: this.storage.blocklist is undefined
blocklist /js&css/web-accessible/www.youtube.com/blocklist.js:61
ytElementsHandler /js&css/web-accessible/functions.js:44
childHandler /js&css/web-accessible/functions.js:10
childHandler /js&css/web-accessible/functions.js:14
childHandler /js&css/web-accessible/functions.js:14
childHandler /js&css/web-accessible/functions.js:14
observer /js&css/web-accessible/init.js:15
MutationCallback* /js&css/web-accessible/init.js:8

ImprovedTube added a commit that referenced this issue May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: In Progress
Development

No branches or pull requests

4 participants