Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: PiP Scrub, volume, and previous/next controls #2234

Open
Chaseos opened this issue May 2, 2024 · 2 comments
Open

Feature Request: PiP Scrub, volume, and previous/next controls #2234

Chaseos opened this issue May 2, 2024 · 2 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Chaseos
Copy link

Chaseos commented May 2, 2024

SHORT Table (Summary)
Problem I would like to be able to control the video while not on the browser tab. It frustrates me when I have to stop what I'm doing and return to the browser to go back a few seconds or go to the next video.
Solution Adding scrubbing volume, and previous / next controls would allow me to do that.
Scope Would benefit anyone who uses PiP. I downloaded this extension only for PiP.
@Chaseos Chaseos added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels May 2, 2024
@ImprovedTube
Copy link
Member

hi & thanks! @Chaseos

context:

  • our shortcuts allowing single keys are only for the active tab

    • we can allow global ones too and we can use chrome://extensions/shortcuts too #1565
      • (both of which will work without PiP)
  • we have a feature mixer (currently hidden behind the "⋮"), where you can control the volume of videos playing in the background.

    • chrome added similar some years ago in the top right called "control your music, videos and more"
      • we can check the chrome PiP API more to see if we can add short cuts for it or if we require pull request to the browser/s

@Chaseos
Copy link
Author

Chaseos commented May 2, 2024

I think the best options here (in my opinion) would be:

  • The controls get overlayed on the video when hovering, like the site does
  • The controls are in a separate area, below the PiP video
  • The controls are shown when you click the extension button at the top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants