Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual/audio feedback for like/dislike/unrate keyboard shortcuts for fullscreen mode #2217

Open
Large-Croissant opened this issue Apr 28, 2024 · 1 comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Large-Croissant
Copy link

PROBLEM: There is no feedback for when you like/dislike/unrate a video if you are fullscreen and can not see the buttons under the video. (See how this extension does it)

SOLUTION: Add a quick popup to the screen in the style of the default one when you play/pause a video that indicates your action

ALTERNATIVES: An alternative could be a quick sound that plays. That could be a good option to add as well for people to choose

RELEVANCE / SCOPE: This would be a good change to make by default, but of course, options to change it or revert it to how it is currently would be a good idea to have too. This is something relevant to most, if not all YouTube users.

"SIDE EFFECTS": One possible side effect could be it being annoying to users, but this can easily be fixed with an option to disable the feature. The only other thing I can think of that it could conflict with is any of YouTube's own popups on the player, but it's such a quick little thing that I don't imagine it would cause much of an issue, if any.

SHORT Table (Summary)
Problem No feedback for like/dislike/unrate shortcut in fullscreen mode
Solution Add popup (and possibly sound)
Alternatives Sound notification
Scope Anyone who rates a video
Side effects Possible annoyance, but can be disabled in settings
@Large-Croissant Large-Croissant added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Apr 28, 2024
@ImprovedTube
Copy link
Member

hi & thanks! @Large-Croissant An animation and a sound could both be sub-options enabled by default
and appearing below the short cut, only once a shortcut is set.

Each could have another suboption: Only in fullscreen mode
Or this could be another two 3-way switches..

Debate: Why have a shortcut at all for something done relatively rarely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: No status
Development

No branches or pull requests

2 participants