Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take next character into account for *uppercase* german umlauts #267

Open
ThomasLandauer opened this issue Jul 15, 2020 · 0 comments
Open

Comments

@ThomasLandauer
Copy link
Contributor

According to https://github.com/cocur/slugify/blob/master/Resources/rules/austrian.json#L3 and https://github.com/cocur/slugify/blob/master/Resources/rules/german.json#L3 "Österreich" will be slugified to "OEsterreich", but it should be "Oesterreich". However, when it's all uppercase "OESTERREICH" is correct (not "OeSTERREICH"). So the perfect (?) solution probably would be to check if the next character is uppercase too, then go for E or e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant