Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony Flex Recipe #208

Open
kiler129 opened this issue Jun 29, 2018 · 6 comments
Open

Symfony Flex Recipe #208

kiler129 opened this issue Jun 29, 2018 · 6 comments

Comments

@kiler129
Copy link

The bundle integrates nicely with Symfony, but I discovered setup has to be done manually.
Maybe the maintainer can add Symfony Flex recipe for 4.x integration?

@Spomky
Copy link

Spomky commented Jul 9, 2018

The package type is library. A Symfony Flex recipe only works when packages are type of symfony-bundle (among other validation rules).

@OskarStark
Copy link
Contributor

@Spomky but it is shipped with a bundle implementation, so a receipe would be a great idea!

@Spomky
Copy link

Spomky commented Jul 16, 2018

Sure it is a great idea.
What I wanted to highlight is that you cannot create a Flex receipe using this library as-is unless the package type is changed from library to symfony-bundle.

@florianeckerstorfer
Copy link
Member

@Spomky I can only add one type to composer.json, right? The problem is that this repo is not only a symfony-bundle that offers integrations to a bunch of different frameworks. Labelling as a symfony-bundle in Composer would confuse more people than it helps, I think.

@kubawerlos
Copy link
Contributor

A Symfony Flex recipe only works when packages are type of symfony-bundle

but only

if a bundle is registered in the manifest

PHP CS Fixer has recipe beign library.

@DemigodCode
Copy link

Hey, the symfony bundle version will be available soon. But a flex recipe is not recommended, if the bundle has no configuration. This new bundle will have the same configuration as now, but it'll have no default configuration. See https://github.com/symfony/recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants