Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v24.1 release notes should mention expected increase in memory usage #18540

Open
nvanbenschoten opened this issue May 13, 2024 · 0 comments
Open
Assignees

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented May 13, 2024

Nathan VanBenschoten (nvanbenschoten) commented:

In v24.1, we made the following change: cockroachdb/cockroach#119605. This PR sets a default value for the GOGC of 300, which will allow the Go memory to quadruple before each garbage collection. The old default was to GC each time the memory doubled.

This will look like an increase in "Memory usage" in the Hardware dashboard and an increase in "Go total memory usage" in the Runtime dashboard. This should not cause OOMs, as the Go memory limit (controlled by --max-go-memory flag) will still prevent Go memory from growing too large. Still, it may be concerning to users who are not expecting it (like it was in this thread), so we should call it out in the release notes.

Jira Issue: DOC-10266

@rmloveland rmloveland self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants