Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: figure out handling for old CreationClusterVersion #124351

Open
RaduBerinde opened this issue May 17, 2024 · 0 comments
Open

jobs: figure out handling for old CreationClusterVersion #124351

RaduBerinde opened this issue May 17, 2024 · 0 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented May 17, 2024 •
edited by cockroach-jira-scripts

Currently we preserve backward compatibility with one or two previous releases, and remove all code that is compatible with older releases.

But there is no migration or anything like that which checks if there are still jobs created at an old version (see CreationClusterVersion)

One option is to automatically fail any jobs that have a CreationClusterVersion that is below MinSupported. For long lived jobs, it is up to that job specific code to bump the creation version through upgrades.

A bit more context in this discussion: #124286 (comment)

Jira issue: CRDB-38842
@RaduBerinde RaduBerinde added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 17, 2024
@RaduBerinde RaduBerinde mentioned this issue May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RaduBerinde