New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/changefeedccl: unskip TestChangefeedOnlyInitialScanCSV for pulsar sink #119289
Labels
A-cdc
Change Data Capture
A-testing
Testing tools and infrastructure
branch-master
Failures on the master branch.
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
P-2
Issues/test failures with a fix SLA of 3 months
T-cdc
Milestone
Comments
cockroach-teamcity
added
branch-master
Failures on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
T-cdc
labels
Feb 16, 2024
ccl/changefeedccl.TestChangefeedOnlyInitialScanCSV failed on master @ c9c3cc5f3c3a4a6ab556f4b9d5b6ec0381901bdb:
Parameters:
|
ccl/changefeedccl.TestChangefeedOnlyInitialScanCSV failed on master @ 7bb52a7d1c75d5adfdfa53e5fcff6f5e6497408f:
Parameters:
|
jayshrivastava
removed
the
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
label
Feb 27, 2024
Will skip this test |
jayshrivastava
added a commit
to jayshrivastava/cockroach
that referenced
this issue
Feb 28, 2024
Informs: cockroachdb#119289 Release note: None Epic: None
craig bot
pushed a commit
that referenced
this issue
Feb 28, 2024
119535: roachtest: fail tests if monitor encounters an error r=srosenberg a=renatolabs This commit updates the roachprod and roachtest monitors to 1) send an event when the monitor is abruptly terminated (i.e., reader stream sees an EOF when the associated context is *not* canceled); and 2) return any errors encountered by the roachprod monitor in roachtest, causing the currently running test to fail. The error has TestEng ownership so that teams are not be pinged on these kinds of flakes. The main purpose of this change is for the monitor to fail in situations where the monitored node is preempted by the cloud provider. Previously, these events would be ignored, leading to a test timeout, wasting resources and leading to confusing test failures being reported on GitHub. Fixes: #118563. Release note: None 119725: changefeedccl: disable TestChangefeedOnlyInitialScanCSV with pulsar r=rharding6373 a=jayshrivastava Informs: #119289 Release note: None Epic: None 119732: master: Update pkg/testutils/release/cockroach_releases.yaml r=rail a=github-actions[bot] Update pkg/testutils/release/cockroach_releases.yaml with recent values. Epic: None Release note: None Release justification: test-only updates Co-authored-by: Renato Costa <renato@cockroachlabs.com> Co-authored-by: Jayant Shrivastava <jayants@cockroachlabs.com> Co-authored-by: CRL Release bot <teamcity@cockroachlabs.com>
rharding6373
changed the title
ccl/changefeedccl: TestChangefeedOnlyInitialScanCSV failed
ccl/changefeedccl: unskip TestChangefeedOnlyInitialScanCSV for pulsar sink
Mar 4, 2024
We should fix and unskip this test before making pulsar available for beta. |
rharding6373
added a commit
to rharding6373/cockroach
that referenced
this issue
Apr 29, 2024
Although the comments in mock pulsar sink say that emitting messages and flushing are synchronous, the use of a buffered channel to transmit messages from the mock producer to the test feed makes it asynchronous. This leads to problems where the consumer (the test) may not have stored the data in a "durable" way before the changefeed job completes. As a result, tests can be flaky as it does not always look like all rows have been emitted. This PR makes the mock pulsar sink synchronous by using an unbuffered channel. Fixes: cockroachdb#119289 Informs: cockroachdb#118899 Epic: CRDB-9180 Release note: None
craig bot
pushed a commit
that referenced
this issue
May 6, 2024
123228: changefeedccl: make mock pulsar sink synchronous r=asg0451 a=rharding6373 Although the comments in mock pulsar sink say that emitting messages and flushing are synchronous, the use of a buffered channel to transmit messages from the mock producer to the test feed makes it asynchronous. This leads to problems where the consumer (the test) may not have stored the data in a "durable" way before the changefeed job completes. As a result, tests can be flaky as it does not always look like all rows have been emitted. This PR makes the mock pulsar sink synchronous by using an unbuffered channel. Fixes: #119289 Informs: #118899 Epic: CRDB-9180 Release note: None Co-authored-by: rharding6373 <harding@cockroachlabs.com>
rharding6373
added
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
A-testing
Testing tools and infrastructure
labels
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-cdc
Change Data Capture
A-testing
Testing tools and infrastructure
branch-master
Failures on the master branch.
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
P-2
Issues/test failures with a fix SLA of 3 months
T-cdc
ccl/changefeedccl.TestChangefeedOnlyInitialScanCSV failed on master @ 617bf347978dcc0d711399b1a76402d7f88de958:
Parameters:
attempt=1
run=7
shard=14
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-36130
The text was updated successfully, but these errors were encountered: