Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for 10.1.* version #365

Closed
naveen12 opened this issue Aug 28, 2023 · 6 comments
Closed

support for 10.1.* version #365

naveen12 opened this issue Aug 28, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@naveen12
Copy link

Hi Team,

first of all thanks to all contributors
its a great tool, which produces result files from sonarqube community edition

may i know when you are planning to support 10.1.* version

@naveen12 naveen12 added the enhancement New feature or request label Aug 28, 2023
@rcfja
Copy link

rcfja commented Oct 2, 2023

And now Sonarqube 10.2.* is out, which we would like to use this plugin on that.

@ThalianSvk
Copy link

Hello, my colleague Petr Mach and I have updated the compatibility with version sonarqube 10.x. It is necessary to modify pom.xml, api.js, AbstractDataProvider.java and AbstractQualityGateProvider.java. I am attaching the updated files in a zip folder.
sonar-cnes-report-updated-files.zip

@almas
Copy link

almas commented Oct 6, 2023

Hello, my colleague Petr Mach and I have updated the compatibility with version sonarqube 10.x. It is necessary to modify pom.xml, api.js, AbstractDataProvider.java and AbstractQualityGateProvider.java. I am attaching the updated files in a zip folder. sonar-cnes-report-updated-files.zip

Can you create a pull request?

To contribute to a project on GitHub.com using the fork and pull request workflow, you need to follow these steps:

  • Fork the repository you want to contribute to by clicking the Fork button on the top-right corner of the repository page. This will create a copy of the repository under your own account.
  • Clone your forked repository to your local machine by using the command git clone [URL], where [URL] is the URL of your forked repository. You can find the URL by clicking the Code button on your forked repository page and copying it from there.
  • Add the original repository as a remote to your local clone by using the command git remote add upstream [URL], where [URL] is the URL of the original repository. This will allow you to fetch changes from the original repository and keep your fork up to date.
  • Create a new branch for your changes by using the command git checkout -b [branch-name], where [branch-name] is a descriptive name for your branch. This will help you isolate your changes from the main branch and make it easier to merge them later.
  • Make your changes in the local branch and commit them by using the commands git add [files] and git commit -m "[message]", where [files] are the files you modified and [message] is a brief description of your changes.
  • Push your changes to your forked repository by using the command git push origin [branch-name], where [branch-name] is the name of your local branch. This will update your forked repository on GitHub with your changes.
  • Create a pull request from your forked repository to the original repository by clicking the Pull request button on your forked repository page. You can choose which branch of your forked repository you want to compare with which branch of the original repository, and write a title and description for your pull request. You can also review the changes you made and add comments or suggestions if needed.
  • Wait for feedback from the original repository owner or maintainers. They may review your pull request, request changes, approve it, or merge it. You can also respond to their comments or questions, or make additional changes if needed.

For more information and examples, you can refer to these resources:

(1) Creating a pull request from a fork - GitHub Docs. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork.
(2) Contributing to projects - GitHub Docs. https://docs.github.com/en/get-started/quickstart/contributing-to-projects.
(3) How To: Fork a GitHub Repository & Submit a Pull Request. https://bing.com/search?q=how+to+contribute+fork+and+pull+request+on+github.com.
(4) Github’s Fork & Pull Workflow for Git Beginners - Reflectoring. https://reflectoring.io/github-fork-and-pull/.
(5) github - Git - Creating pull request without forking - Stack Overflow. https://stackoverflow.com/questions/48110207/git-creating-pull-request-without-forking.

almas added a commit to almas/sonar-cnes-report that referenced this issue Oct 9, 2023
Just little bit improved and added
@ThalianSvk's change.
But I don't fully tested it by myself yet.
almas added a commit to almas/sonar-cnes-report that referenced this issue Oct 9, 2023
@almas almas mentioned this issue Oct 9, 2023
12 tasks
@almas
Copy link

almas commented Oct 9, 2023

Hello, my colleague Petr Mach and I have updated the compatibility with version sonarqube 10.x. It is necessary to modify pom.xml, api.js, AbstractDataProvider.java and AbstractQualityGateProvider.java. I am attaching the updated files in a zip folder. sonar-cnes-report-updated-files.zip

@ThalianSvk Thank you. I just little bit edited your code and created pull request.

@louisjdmartin
Copy link
Member

louisjdmartin commented Nov 3, 2023

Hi @naveen12 ,

As our ressources are limited, we only support LTS version of Sonarqube. So Sonarqube 10 support is planned for ... Sonarqube 10 LTS.

I see some contributors that purpose some workaround to make it work, I suggest you to check them, we will review and accept related pull request from @almas a litlle bit later. As explained on the Pull Request, on every major upgrades we have to review a lot of "underground" things (For every major release, SonarQube may changes API or internal behavior).

Thanks a lot for all your contribution.

I close this issue for now as upgrade is planned for Sonarqube 10 LTS

@louisjdmartin louisjdmartin reopened this Nov 3, 2023
@louisjdmartin louisjdmartin closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
@ZweiDM
Copy link

ZweiDM commented Nov 6, 2023

For those who can't wait for another LTS:
A temporary workaround is commenting out line 129 in ReportModelFactory.java.

change
report.setQualityGate(qualityGateProvider.getProjectQualityGate());
to
// report.setQualityGate(qualityGateProvider.getProjectQualityGate());

As a consequence, the name of the quality gate will be missing in the report, but the report generation doesn't crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants