SSH handler does not respect UtcTimeOff

[vydrazde]

Once the SSH handler starts running, it does not turn off when UtcTimeOff passes.

It likely gets stuck in this loop

while (true)
{
    var cmd = timelineEvent.CommandArgs[_random.Next(0, timelineEvent.CommandArgs.Count)];
    if (!string.IsNullOrEmpty(cmd.ToString()))
    {
        this.Command(handler, timelineEvent, cmd.ToString());
    }
    Thread.Sleep(Jitter.JitterFactorDelay(timelineEvent.DelayAfterActual, jitterfactor)); ;
}

where WorkingHours.Is(handler); is not called. It could be called as the condition of the loop.

[rbreesems]

I will fix this in next PR from my branch.

[rbreesems]

Actually, the while(true) needs to be removed entirely as the WorkingHours.Is(handler) is called in the Ex function and the loop attribute will cause it to loop.

[rbreesems]

This is a problem with ftp, sftp, wmi also., will fix.

[rbreesems]

FYI, this was fixed in a PR that was merged yesterday.

[vydrazde]

Great! Could you make a new build so I can test this?

[rbreesems]

Dustin makes the builds so I am sure one will be done.

[sei-dupdyke]

Sorry for delay — v8.0.51.50 is now available.

(I need to automate all these builds)

[vydrazde]

Thanks a lot! I can confirm that this is fixed.

[sei-dupdyke]

The power of the team on this one 💪 - thanks all.